-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<algorithm>: Implemented ranges::move #888
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nits from my side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you accidentally checked in an empty file named cmake
in the root of the repo - please git rm
it.
FYI, GitHub is saying "Ahana Mukhopadhyay and others added 2 commits 4 hours ago" because your branch contains commits variously marked with your school and Microsoft emails, but your GitHub account has verified only your school address. (This is separate from the whole "join the Microsoft organization" linking process. I have no access to your account, I can just tell this from the commit history and what GitHub is displaying.) This is easy to fix (although not necessary). If you click on your avatar in the upper right, "Settings > Emails" will allow you to "Add email address". Adding your Microsoft address as a non-primary address won't affect how you log into GitHub, but will teach it that commits marked with that address are yours. (Similarly, I use my home email as primary, while my |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me modulo necessary clang-formatting and some minor comments. Thanks for implementing this algorithm! 😺
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still three comments here that need to be resolved.
Thanks for implementing this part of the C++20 ranges library, and congratulations on your first microsoft/STL commit! 😺 🎉 😸 |
Co-authored-by: Casey Carter <Casey@Carter.net>
Co-authored-by: Casey Carter <Casey@Carter.net>
Co-authored-by: Casey Carter <Casey@Carter.net>
Co-authored-by: Casey Carter <Casey@Carter.net>
No description provided.